----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4123/#review13697 -----------------------------------------------------------
Ship it! Ship It! - Mark Michelson On Nov. 5, 2014, 7:01 p.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4123/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 7:01 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24257 and ASTERISK-24447 > https://issues.asterisk.org/jira/browse/ASTERISK-24257 > https://issues.asterisk.org/jira/browse/ASTERISK-24447 > > > Repository: Asterisk > > > Description > ------- > > This patch can be broken into two logical changes. The first is to allow the > DTMF feature hooks to collect digits while passing frames from the bridge > (ASTERISK-24447). The secod is to allow an agent pool agent to interrupt the > alerting playback file with DTMF (ASTERISK-24257). The agent interrupting > the alerting playback builds on the ASTERISK-24447 part because it knows what > digit interrupted the playback and needs to be able to pass that digit to the > DTMF hook digit collection code. > > * Made collecting DTMF digits for the DTMF feature hooks not block receiving > frames from the bridge. (Changes in bridge_channel.c and bridge_channel.h) > > * Made collecting DTMF digits possible by other bridge hooks if there is a > need. > > * Made agent able to interrupt the alerting beep playback with DTMF. Any > digit can interrupt if the call does not need to be acknowledged. Only the > first digit of the acknowledgement can interrupt if the call needs to be > acknowledged. (Changes in app_agent_pool.c) > > > Diffs > ----- > > /branches/12/main/bridge_channel.c 427333 > /branches/12/include/asterisk/bridge_channel.h 427333 > /branches/12/apps/app_agent_pool.c 427333 > > Diff: https://reviewboard.asterisk.org/r/4123/diff/ > > > Testing > ------- > > With the patch > 1) Agent can interrupt the beep playback with any digit if an acknowledgement > is not required. > 2) Agent can interrupt the beep playback with the first digit of the > configured acknowledgement. Other digits are ignored. The acknowledgement > could be one or more digits. > 3) Agent can still wait for the playback to end. > > 4) Collecting DTMF digits for the DTMF feature hooks does not block receiving > frames from the bridge. Tested by using ControlPlayback application through > a local channel chain that had other DTMF feature hooks starting with '*'. > When I pressed the '*', the rewinding of the playback was delayed by the > digit collection interdigit timeout time but the audio was not discarded > during the interdigit timeout time. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
