-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4163/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 12:56 p.m.)
Review request for Asterisk Developers.
Changes
-------
Added some error messages for critical failure paths.
Bugs: ASTERISK-24501
https://issues.asterisk.org/jira/browse/ASTERISK-24501
Repository: Asterisk
Description
-------
This change corrects message ordering in cases where a channel-related message
can be received after a Stasis/ARI application has received the StasisEnd
message. The StasisEnd message was being passed to applications directly
without waiting for the channel topic to empty.
As a result of this fix, other bugs were also identified and fixed:
* StasisStart messages were also being sent directly to apps and are now routed
through the stasis message bus properly
* Masquerade monitor datastores were being removed at the incorrect time in
some cases and were causing StasisEnd messages to not be sent
* General refactoring where necessary for the above
* Unsubscription on StasisEnd timing changes to prevent additional messages
from following the StasisEnd when they shouldn't
A channel sanitization function pointer was added to reduce processing and AO2
lookups
This also required minor changes to tests using AriTestObject or its subclasses
since StasisEnd is no longer reliably received before the test shuts the
websocket down. This is due to the AriTestObject relying on AMI events to
decide when the test is over which won't necessarily come in at the same time
as the corresponding ARI events since they arrive via two different transports.
Diffs (updated)
-----
branches/12/res/stasis/stasis_bridge.c 427539
branches/12/res/stasis/app.c 427539
branches/12/res/stasis/app.h 427539
branches/12/res/res_stasis.c 427539
branches/12/include/asterisk/stasis_app.h 427539
branches/12/include/asterisk/stasis.h 427539
Diff: https://reviewboard.asterisk.org/r/4163/diff/
Testing
-------
Ran all the REST API tests to verify that they passed.
Thanks,
opticron
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
