> On Nov. 13, 2014, 7:30 p.m., Mark Michelson wrote: > > Looks good to me. The only suggestion I have is to modify the > > tests/apps/confbridge/confbridge_marked_unmarked test in the testsuite to > > expect the "conf-hasleft" sound to be played back in scenarios 2 and 3 to > > the "Normal-user" channel.
I can't, the sound file is played into the conference and not to individual channels. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4177/#review13749 ----------------------------------------------------------- On Nov. 13, 2014, 6:53 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4177/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2014, 6:53 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > Currently if a marked user leaves a conference bridge and all other channels > return to a musiconhold state the "leader has left" sound is not played. This > is because musiconhold is started BEFORE the "leader has left" sound is > played. This change plays the leader has left sound first and then starts > musiconhold. > > > Diffs > ----- > > /branches/11/apps/confbridge/conf_state_multi_marked.c 427675 > > Diff: https://reviewboard.asterisk.org/r/4177/diff/ > > > Testing > ------- > > Joined two channels: 1 as normal, 1 as marked. Hung up the marked channel. > Confirmed that the "leader has left" sound was played and then music on hold > started. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
