> On Nov. 4, 2014, 3:53 p.m., Mark Michelson wrote: > > Why the change to being a standalone script? I personally like the idea of > > it being a filter more. > > George Joseph wrote: > I changed it locally months back for 2 reasons... > The first was that runtests wasn't pre-calculating and printing the total > number of tests to run back then. So I had to run runtests twice, once to > get the total number (in dry-run mode) then again for real. > > The other one was buffering problems. ./runtests.py | pretty_print > wasn't printing output as often as it should so I was always doing > python -u ./runtests.py | pretty_print. > > Honestly, I didn't think anyone else was using it. :) > > I can change it back to a filter if that's more useful. > > > > > Matt Jordan wrote: > Now that I know it exists I'm going to be using it more often :-) > > Personally, I like that it is a filter. I think that's kinda helpful - > and the outpupt is certainly much nicer to look at then the current output > from runtests when just running a subset of tests. > > We could modify runtests.py to output things unbuffered (or possibly to > unbuffer things with a particular command line switch) - something like this > perhaps: > > > http://stackoverflow.com/questions/881696/unbuffered-stdout-in-python-as-in-python-u-from-within-the-program
Easily changed. Stay tuned. - George ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4145/#review13673 ----------------------------------------------------------- On Nov. 3, 2014, 8:43 a.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4145/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2014, 8:43 a.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > Updated contrib/scripts/pretty_print so it works with recent runtests.py > changes. Also changed it from a filter to a standalone script. > > > Diffs > ----- > > asterisk/trunk/contrib/scripts/pretty_print 5878 > > Diff: https://reviewboard.asterisk.org/r/4145/diff/ > > > Testing > ------- > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
