----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4200/#review13835 -----------------------------------------------------------
Ship it! /branches/13/main/manager.c <https://reviewboard.asterisk.org/r/4200/#comment24304> Concatenating all permissions strings together gets a length of ~105. Even allowing for extra room out of safety, using a 128 constant instead of 256 would be appropriate. - Mark Michelson On Nov. 20, 2014, 12:08 a.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4200/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2014, 12:08 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > When shutting down Asterisk that has an active AMI connection, you get > several "failed to extend from %d to %d" messages because use of the > EVENT_FLAG_SHUTDOWN attempts to add all AMI permission strings to the event. > > * Created MAX_AUTH_PERM_STRING to use when creating stack based struct > ast_str variables used with the authority_to_str() and > user_authority_to_str() functions instead of a variety of magic numbers that > could be too small. > > * Added a special check for EVENT_FLAG_SHUTDOWN to authority_to_str() so it > will not attempt to add all permission level strings. > > Note: The patch will be applied to v11+ with appropriate updates per branch. > > > Diffs > ----- > > /branches/13/main/manager.c 428298 > > Diff: https://reviewboard.asterisk.org/r/4200/diff/ > > > Testing > ------- > > With the patch, the "failed to extend from %d to %d" messages no longer > happen when shutting down Asterisk that has an AMI connection. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
