----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4178/#review13885 -----------------------------------------------------------
branches/13/res/res_pjsip_outbound_publish.c <https://reviewboard.asterisk.org/r/4178/#comment24392> This can be static branches/13/res/res_pjsip_outbound_publish.c <https://reviewboard.asterisk.org/r/4178/#comment24393> This is both a set and get function. branches/13/res/res_pjsip_outbound_publish.c <https://reviewboard.asterisk.org/r/4178/#comment24395> Should this also be in the lock? Is there a possible race condition here? branches/13/res/res_pjsip_outbound_publish.c <https://reviewboard.asterisk.org/r/4178/#comment24394> <3 branches/13/res/res_pjsip_outbound_publish.c <https://reviewboard.asterisk.org/r/4178/#comment24396> This differs from the previous code. Even if you are using the state some elements may have changed which dictate a new outbound PUBLISH, so the task should still be pushed. branches/13/res/res_pjsip_outbound_publish.c <https://reviewboard.asterisk.org/r/4178/#comment24397> Per my race condition comment I think you may want to just end up doing this at load time. - Joshua Colp On Dec. 4, 2014, 6:13 p.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4178/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 6:13 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24514 > https://issues.asterisk.org/jira/browse/ASTERISK-24514 > > > Repository: Asterisk > > > Description > ------- > > When using a non-default sorcery wizard (in this instance realtime) for > outbound publishes Asterisk will crash after a stack overflow occurs due to > the code infinitely recursing. The fix entails removing the outbound publish > state dependency from the outbound publish sorcery object and instead keeping > an in memory container that can be used to lookup the state when needed. > > > Diffs > ----- > > branches/13/res/res_pjsip_outbound_publish.c 428944 > > Diff: https://reviewboard.asterisk.org/r/4178/diff/ > > > Testing > ------- > > On top of running the current testsuite tests I also manually tested various > configurations and scenarios using a static configuration file as well as > dynamic realtime. Verified that the crash no longer occurs and the > potentially affected functionality works as expected (for instance, module > [re]loading). > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
