----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4276/#review13998 -----------------------------------------------------------
I think the key for me understanding and accepting this change is to decipher why: "When the module is loaded again, a reload of res_pjsip is triggered which causes the observer to do a reload as opposed to a load of the file" this happens. Why does a reload of res_pjsip cause the observer to perform a reload instead of a load? - Mark Michelson On Dec. 17, 2014, 5:24 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4276/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 5:24 p.m.) > > > Review request for Asterisk Developers and Joshua Colp. > > > Repository: Asterisk > > > Description > ------- > > The earlier patch fixed the test breakage but caused a problem when > res_pjsip_config_wizard is unloaded then loaded again. > > When res_pjsip_config_wizard is unloaded, config still has the mtime of > pjsip_wizard.conf cached. When the module is loaded again, a reload of > res_pjsip is triggered which causes the observer to do a reload as opposed to > a load of the file. The result is FILEUNCHANGED and the wizard never loads > any objects. The file has to be cached for normal operation so the easiest > solution was to expose the config cache_remove function and call it when > res_pjsip_config_wizard is unloaded. Now if res_pjsip_config_wizard is > loaded, it gets a good config instead of FILEUNCHANGED even though it's a > reload. > > > Diffs > ----- > > branches/13/res/res_pjsip_config_wizard.c 429698 > > Diff: https://reviewboard.asterisk.org/r/4276/diff/ > > > Testing > ------- > > Tested the unloading and re-loading of the module as well as config reload > and pjsip reload to make sure the correct objects were updated. > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
