----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4304/#review14121 -----------------------------------------------------------
Ship it! Ship It! - Joshua Colp On Jan. 7, 2015, 3:52 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4304/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2015, 3:52 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > There are 2 issues with reloading registrations... > > 1. The 'can_reuse_registration' test wasn't considering the intervals or > expiration in its determination of whether a registration changed or not so > if you changed any of the intervals or the expiration and reloaded, the > object would get reloaded but the actual timers wouldn't change. > can_reuse_registration now does a sorcery diff on the old and new objects > instead of discretely testing certain fields. Now if you change expiration > for instance, and reload, the timer is updated and re-registration will occur > on the new value. > > 2. If you mung up your password on an outbound registration you get a > permanent failure. If you fix the password (on the outbound_auth object) and > reload, nothing tells outbound_registration to try again because the > registration itself didn't change. This patch adds an observer on the "auth" > object type and if any auth changes, existing registration states are > searched and those in a REJECTED_PERMANENT state are retried. > > > Diffs > ----- > > branches/13/res/res_pjsip_outbound_registration.c 430293 > > Diff: https://reviewboard.asterisk.org/r/4304/diff/ > > > Testing > ------- > > Tested locally with various scenarios using Wireshark to make sure intervals > have changed and that auths are being retried. > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
