> On Jan. 26, 2015, 6:14 p.m., rmudgett wrote: > > /branches/13/apps/confbridge/include/confbridge.h, line 242 > > <https://reviewboard.asterisk.org/r/4372/diff/1/?file=71081#file71081line242> > > > > This really should be a define instead of a magic number. Hmm... The > > bridge profile name is also set at 64.
I agree that this should be a #define. I'll make the bridge profile 128 as well, although I'd prefer to not bump the scope on this further. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4372/#review14292 ----------------------------------------------------------- On Jan. 26, 2015, 10:28 a.m., Matt Jordan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4372/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2015, 10:28 a.m.) > > > Review request for Asterisk Developers and Jonathan Rose. > > > Bugs: ASTERISK-24723 > https://issues.asterisk.org/jira/browse/ASTERISK-24723 > > > Repository: Asterisk > > > Description > ------- > > When issuing a 'confbridge list XXXX' CLI command, the resulting output no > longer displays the menu associated with a ConfBridge participant: > > Channel Flags User Profile Bridge Profile Menu > CallerID > ============================== ====== ================ ================ > ================ ================ > PJSIP/1601-00000004 default_user default_bridge > 1601 > > The issue was caused by ASTERISK-22760. When that patch was done, it removed > the copying of the menu name associated with the user from the actual user > profile. > > This patch fixes the issue by copying the menu name over to the user profile > when the menu hooks are applied to the user. Since that function now does a > little bit more than just apply the hooks, the name of the function has been > changed to cover the copying of the menu name over as well. > > In addition, there is a disparity between the menu name length as it is > stored on the conf_menu structure and the confbridge_user structure; this > patch makes the lengths match so that a strcpy can be used. > > > Diffs > ----- > > /branches/13/apps/confbridge/include/confbridge.h 431019 > /branches/13/apps/confbridge/conf_config_parser.c 431019 > > Diff: https://reviewboard.asterisk.org/r/4372/diff/ > > > Testing > ------- > > Ran the CLI command. The output now shows the menu associated with the user. > > > Thanks, > > Matt Jordan > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
