-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4430/
-----------------------------------------------------------
Review request for Asterisk Developers.
Bugs: ASTERISK-22670, ASTERISK-24689 and ASTERISK-24740
https://issues.asterisk.org/jira/browse/ASTERISK-22670
https://issues.asterisk.org/jira/browse/ASTERISK-24689
https://issues.asterisk.org/jira/browse/ASTERISK-24740
Repository: Asterisk
Description
-------
Processing an AOC-E event that does not or no longer has a channel
association causes a crash.
The problem with posting AOC events to the channel topic is that AOC-E
events don't always have a channel association and posting the event to
the all channels topic is just wrong. AOC-E events do however have their
own charging association method to refer to the agreement with the
charging entity.
* Changed the AOC events to post to the AMI manager topic instead of the
channel topics. If a channel is associated with the event then channel
snapshot information is supplied with the AMI event.
* Eliminated RAII_VAR() usage in aoc_to_ami() and ast_aoc_manager_event().
This patch supercedes the patch on Review:
https://reviewboard.asterisk.org/r/4427/
Diffs
-----
/branches/13/main/aoc.c 431915
Diff: https://reviewboard.asterisk.org/r/4430/diff/
Testing
-------
Created a dummy AOC-E event with and without a channel association when an
ISDN call came in. The AMI AOC-E events were generated as expected and
didn't crash.
Thanks,
rmudgett
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
