----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4422/#review14487 -----------------------------------------------------------
Ship it! Ship It! - Mark Michelson On Feb. 14, 2015, 2:05 a.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4422/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2015, 2:05 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > * Fixed hangup handling of the session->channel after answer if the > ast_channel_move() or ast_bridge_impart() fails. We are still the thread > controlling the session->channel so we need to call ast_hangup() to kill > the channel. > > * Fixed debug messages in refer_incoming_invite_request() referencing > incorrect channnels on success. Code comments now say why the > session->channel cannot be used. > > > Diffs > ----- > > /branches/13/res/res_pjsip_refer.c 431750 > > Diff: https://reviewboard.asterisk.org/r/4422/diff/ > > > Testing > ------- > > Using testsuite test > tests/channels/pjsip/transfers/attended_transfer/nominal/callee_remote > 1) Ran with patch. The debug log on ast2 was as expected. > 2) Ran with patch and sabotaged code to "fail" > ast_channel_move()/ast_bridge_impart(). The debug log on ast2 was as > expected. > 3) Ran with patch and sabotaged code to "fail" the initial test if the INVITE > was a re-INVITE. The debug log on ast2 was as expected. > > Funny thing is the testsuite test passed for the three scenarios but a > reactor timeout happened on 2 and 3. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
