> On Feb. 20, 2015, 11:03 a.m., Corey Farrell wrote: > > /branches/11/include/asterisk/utils.h, lines 946-948 > > <https://reviewboard.asterisk.org/r/4370/diff/2/?file=71539#file71539line946> > > > > I feel that configure should create a #define for the type of nested > > procedure supported. This should use results of configure (#ifdef > > HAVE_CLANG_BLOCKS), instead of implementing it's own direct tests.
Hm. I'm not sure how much better that makes this, since I find parsing out a configure.ac file to be much harder than the #defines in a header. What specifically are you envisioning? Right now, I'm having a hard time determining how this would look in the configure script and how it would be reflected here. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4370/#review14513 ----------------------------------------------------------- On Feb. 19, 2015, 10:09 p.m., Matt Jordan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4370/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 10:09 p.m.) > > > Review request for Asterisk Developers and Diederik de Groot. > > > Bugs: ASTERISK-20850 > https://issues.asterisk.org/jira/browse/ASTERISK-20850 > > > Repository: Asterisk > > > Description > ------- > > This is a continuation of the patch put up for review on r3488. It addresses > the issues found on that review. > > This patch *should* make Asterisk compile under clang. Note that compiling > with --enable-dev-mode will cause Asterisk to fail to compile under clang, as > it detects a number of warnings that aren't fixed under this patch. > > > Diffs > ----- > > /branches/11/makeopts.in 432011 > /branches/11/main/Makefile 432011 > /branches/11/include/asterisk/utils.h 432011 > /branches/11/include/asterisk/inline_api.h 432011 > /branches/11/configure.ac 432011 > /branches/11/configure UNKNOWN > /branches/11/Makefile 432011 > > Diff: https://reviewboard.asterisk.org/r/4370/diff/ > > > Testing > ------- > > * Compiled Asterisk with and without --enable-dev-mode using gcc. Asterisk > compiles correctly. > * Compiled Asterisk without --enable-dev-mode using clang. Asterisk compiles, > links, and executes. > > Note that you will need the BlocksRuntime to run Asterisk when it is compiled > with clang. > > > Thanks, > > Matt Jordan > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
