----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4459/#review14588 -----------------------------------------------------------
http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c <https://reviewboard.asterisk.org/r/4459/#comment25134> Shouldn't mix declaration and code. Move the declaration to the top of the function. Also, whitespace issue before and after. http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c <https://reviewboard.asterisk.org/r/4459/#comment25135> Whitespace http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c <https://reviewboard.asterisk.org/r/4459/#comment25136> Shouldn't mix declaration and code. - George Joseph On March 4, 2015, 1:51 a.m., Graham Barnett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4459/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 1:51 a.m.) > > > Review request for Asterisk Developers and mattjordan. > > > Bugs: ASTERISK-24786 > https://issues.asterisk.org/jira/browse/ASTERISK-24786 > > > Repository: Asterisk > > > Description > ------- > > Asterisk terminates when playing a voicemail stored in LDAP > > > Diffs > ----- > > http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c 432422 > > Diff: https://reviewboard.asterisk.org/r/4459/diff/ > > > Testing > ------- > > Tested against Microsoft Exchange 2007 > > > Thanks, > > Graham Barnett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev