----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4464/#review14630 -----------------------------------------------------------
Ship it! I'm fine with this. - Kevin Harwell On March 9, 2015, 12:41 p.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4464/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 12:41 p.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > I've run into issues lately in Asterisk 13+ where 5 seconds is not long > enough to complete the Asterisk shutdown, causing it to be killed. This > results in many false failures with REF_DEBUG enabled. I feel the best way > to handle this is to always increase the timeout to 10 seconds. I realize > that REF_DEBUG is the reason it's taking longer, but it's also the reason > that dozens of these timeouts have been resolved. > > If needed I can find a way to check for the existance of a refs log and > double the timeout if found, but I don't think 10 seconds is an unreasonable. > It's tough to tell but I think this issue effects around 30 tests in > 13/trunk (approximate number of tests with unstable results). Once this is > committed it'll be easier to identify and resolve real shutdown timeouts - > where Asterisk wouldn't shutdown no matter how long you wait. > > > Diffs > ----- > > /asterisk/trunk/lib/python/asterisk/asterisk.py 6482 > > Diff: https://reviewboard.asterisk.org/r/4464/diff/ > > > Testing > ------- > > No more shutdown timeouts from tests capable of graceful shutdown. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
