----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4499/#review14710 -----------------------------------------------------------
This change is full of red blobs (extra whitespace). In addition it looks like many lines start with multiple spaces - we use tabs to indent C sources. Please take a look at Coding Guidelines - https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines I have only reviewed this for coding guidelines, once they are fixed someone with a better understanding of PJSIP can take a look. /trunk/res/res_pjsip_dlg_options.c <https://reviewboard.asterisk.org/r/4499/#comment25275> Missing copyright header and ASTERISK_FILE_VERSION declaration. /trunk/res/res_pjsip_dlg_options.c <https://reviewboard.asterisk.org/r/4499/#comment25274> Missing <support_level> /trunk/res/res_pjsip_dlg_options.c <https://reviewboard.asterisk.org/r/4499/#comment25273> Variable declarations are only allowed at the start of a block. I'm not sure but I believe './configure --enable-dev-mode' would have made this produce an error. If you didn't it's best to always compile your patches in dev-mode as it picks up more issues and turns compiler warnings into errors. - Corey Farrell On March 15, 2015, 4:02 a.m., yaron nahum wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4499/ > ----------------------------------------------------------- > > (Updated March 15, 2015, 4:02 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24862 > https://issues.asterisk.org/jira/browse/ASTERISK-24862 > > > Repository: Asterisk > > > Description > ------- > > Respond to OPTIONS message sent on an existing dialog with 200OK. > This feature is vital in order to interoperate with some switches that send > OPTIONS message periodically per active call to make sure it is still alive. > Not responding would cause the switch to disconnect the call. > This functionality used to work on the old SIP channel, but was not > implemented on PJSIP. > > > Diffs > ----- > > /trunk/res/res_pjsip_dlg_options.c PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/4499/diff/ > > > Testing > ------- > > > Thanks, > > yaron nahum > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
