----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4512/#review14748 -----------------------------------------------------------
Ship it! This gets a "ship it!" from me based on the resolver implementation. As the writer of the unit tests, though, I feel like getting approval from someone else would be a good plan. - Mark Michelson On March 19, 2015, 6:36 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4512/ > ----------------------------------------------------------- > > (Updated March 19, 2015, 6:36 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24836 > https://issues.asterisk.org/jira/browse/ASTERISK-24836 > > > Repository: Asterisk > > > Description > ------- > > This change adds a res_resolver_unbound module which uses libunbound and > implements the core DNS resolver API. Queries can be started and cancelled as > expected. Configuration also exists to change the behavior of the resolver > some. Unit tests are present which use the libunbound zone and data API to > add local records and then confirm they can be queried and are as expected. > > > Diffs > ----- > > /trunk/res/res_resolver_unbound.c PRE-CREATION > /trunk/makeopts.in 433107 > /trunk/configure.ac 433107 > /trunk/configs/samples/resolver_unbound.conf.sample PRE-CREATION > /trunk/build_tools/menuselect-deps.in 433107 > > Diff: https://reviewboard.asterisk.org/r/4512/diff/ > > > Testing > ------- > > Hacked in a query to my own domain and confirmed it worked. Also ran the unit > tests and confirmed they pass. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
