----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/ -----------------------------------------------------------
(Updated March 20, 2015, 3:50 p.m.) Review request for Asterisk Developers. Changes ------- Add link to corresponding testsuite test review. Bugs: ASTERISK-24781 https://issues.asterisk.org/jira/browse/ASTERISK-24781 Repository: Asterisk Description ------- Incoming PJSIP call legs that have not been answered yet send unnecessary "180 Ringing" or "183 Progress" messages every time a connected line update happens. If the outgoing channel is also PJSIP then the incoming channel will always send a "180 Ringing" or "183 Progress" message when the outgoing channel sends the INVITE. Consequences of these unnecessary messages: * The caller can start hearing ringback before the far end even gets the call. * Many phones tend to grab the first connected line information and refuse to update the display if it changes. The first information is not likely to be correct if the call goes to an endpoint not under the control of the first Asterisk box. When connected line first went into Asterisk in v1.8, chan_sip received an undocumented option "rpid_immediate" that defaults to disabled. When enabled, the option immediately passes connected line update information to the caller in "180 Ringing" or "183 Progress" messages as described above. * Added "rpid_immediate" option to prevent unnecessary "180 Ringing" or "183 Progress" messages. The default is "no" to disable sending the unnecessary messages. Diffs ----- /branches/13/res/res_pjsip/pjsip_configuration.c 433198 /branches/13/res/res_pjsip.c 433198 /branches/13/include/asterisk/res_pjsip.h 433198 /branches/13/contrib/ast-db-manage/config/versions/23530d604b96_add_rpid_immediate.py PRE-CREATION /branches/13/configs/samples/pjsip.conf.sample 433198 /branches/13/channels/chan_pjsip.c 433198 /branches/13/CHANGES 433198 Diff: https://reviewboard.asterisk.org/r/4473/diff/ Testing (updated) ------- * Ran the tests/channels/pjsip testsuite tests. They still pass. * Made a call chain as follows: 100 -> * -> * -> * -> 200. With the patch there are no unnecessary messages. Without the patch there were several "180 Ringing" messages sent back to the caller. * https://reviewboard.asterisk.org/r/4518/ testsuite test passes. Thanks, rmudgett
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev