Matt Jordan has posted comments on this change. Change subject: Add .gitignore files ......................................................................
Patch Set 1: (3 comments) https://gerrit.asterisk.org/#/c/8/1/.gitignore File .gitignore: Line 3 > While we're here can we add /astroot? This is where ./run-local installs A Sure! https://gerrit.asterisk.org/#/c/8/1/asttest/self-tests/.gitignore File asttest/self-tests/.gitignore: Line 1: **/asttest.log > Nit-pick - just "asttest.log" should do. Fixed https://gerrit.asterisk.org/#/c/8/1/logs/.gitignore File logs/.gitignore: Line 1: [^.]* > Personally I'd prefer that we instead add /logs to the root .gitignore, hav I think having runtests.py look to see if the logs directory exists and create it if not is a good idea - in which case, this .gitignore should get moved up to the top level. I do think that sort of feels like a separate change from this, so if we want to do it as a separate issue, that'd be fine by me. I'd be happy to write that patch as well, if you don't have time :-) -- To view, visit https://gerrit.asterisk.org/8 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibedc56ac80bcb1981b66a6b514cf817f7423f6ec Gerrit-PatchSet: 1 Gerrit-Project: testsuite Gerrit-Branch: master Gerrit-Owner: Matt Jordan <mjor...@digium.com> Gerrit-Reviewer: Corey Farrell <g...@cfware.com> Gerrit-Reviewer: Matt Jordan <mjor...@digium.com> Gerrit-Reviewer: Russell Bryant <russ...@russellbryant.net> Gerrit-HasComments: Yes -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
