----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4525/#review14939 -----------------------------------------------------------
Ship it! I'd prefer promoting the variables in res_calendar to long over downcasting. Looks good to me - thanks! - Matt Jordan On March 27, 2015, 7:38 a.m., Diederik de Groot wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4525/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 7:38 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24917 > https://issues.asterisk.org/jira/browse/ASTERISK-24917 > > > Repository: Asterisk > > > Description > ------- > > clang's static analyzer will throw quite a number warnings / errors during > compilation, some of which can be very helpfull in finding corner-case bugs > > clang compiler warning:-Wabsolute-value > > Changes: > /branches/13/apps/app_queue.c:3687 int -> long for avgholdmins, avgholdsecs; > /branches/13/apps/app_queue.c:6581 int -> long for holdtime, holdtimesecs; > /branches/13/channels/chan_iax2.c:6080 Moved "adjust" here, so it can help > out in casting (ms - p->nextpred) to int > /branches/13/res/res_calendar.c:1109 Not sure if this is prefered over > downcasting to int > > > Diffs > ----- > > /branches/13/res/res_rtp_asterisk.c 433444 > /branches/13/res/res_calendar.c 433444 > /branches/13/main/jitterbuf.c 433444 > /branches/13/channels/chan_iax2.c 433444 > /branches/13/apps/app_queue.c 433444 > > Diff: https://reviewboard.asterisk.org/r/4525/diff/ > > > Testing > ------- > > > Thanks, > > Diederik de Groot > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
