-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4530/#review14961
-----------------------------------------------------------
So, small problem with this change. When compiling with gcc 4.8.2, I get the
following warning:
In function ‘read’,
inlined from ‘inotify_daemon’ at stdtime/localtime.c:380:6:
/usr/include/x86_64-linux-gnu/bits/unistd.h:42:2: error: call to
‘__read_chk_warn’ declared with attribute warning: read called with bigger
length than size of the destination buffer [-Werror]
return __read_chk_warn (__fd, __buf, __nbytes, __bos0 (__buf));
Interestingly, the build agents didn't kick this back. But we'll need to find a
way to get this fixed for gcc as well.
- Matt Jordan
On March 29, 2015, 8:52 p.m., Diederik de Groot wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4530/
> -----------------------------------------------------------
>
> (Updated March 29, 2015, 8:52 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-24917
> https://issues.asterisk.org/jira/browse/ASTERISK-24917
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> clang's static analyzer will throw quite a number warnings / errors during
> compilation, some of which can be very helpfull in finding corner-case
> bugs\nclang compiler warning:-Wgnu-variable-sized-type-not-at-end
>
>
> Diffs
> -----
>
> /branches/13/main/stdtime/localtime.c 433444
>
> Diff: https://reviewboard.asterisk.org/r/4530/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Diederik de Groot
>
>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
