> On April 1, 2015, 1:07 a.m., Matt Jordan wrote: > > trunk/channels/chan_iax2.c, line 12370 > > <https://reviewboard.asterisk.org/r/4536/diff/1/?file=72980#file72980line12370> > > > > The usage of max_retries here feels arbitrary. I'm not against this > > being controlled more dynamically based on the last known qualify time, but > > I'd rather just see that be 4 or 8 here, as appropriate.
Just going to chime in with my agreement here. I'm not sure how max_retries fits into this. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4536/#review15007 ----------------------------------------------------------- On March 26, 2015, 11:42 p.m., Y Ateya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4536/ > ----------------------------------------------------------- > > (Updated March 26, 2015, 11:42 p.m.) > > > Review request for Asterisk Developers and rnewton. > > > Bugs: ASTERISK-24894 > https://issues.asterisk.org/jira/browse/ASTERISK-24894 > > > Repository: Asterisk > > > Description > ------- > > Increase POKE retry window from DEFAULT_MAXMS * 2 (4 seconds) to bigger > number (derived from qualify time; which control POKE retry time). > > > Diffs > ----- > > trunk/channels/chan_iax2.c 432806 > > Diff: https://reviewboard.asterisk.org/r/4536/diff/ > > > Testing > ------- > > - Tried test with multiple qualify values (2 and 10 seconds). > - Tried test with 100% packets loss to ensure that when a POKE packet is > dropped it will be retried couple of time before declaring client > disconnected. > > > Thanks, > > Y Ateya > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
