----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4582/#review15048 -----------------------------------------------------------
branches/13/res/res_pjsip/pjsip_configuration.c <https://reviewboard.asterisk.org/r/4582/#comment25723> This could be flags &= ~(SUPPORT | REQUIRE) branches/13/res/res_pjsip/pjsip_configuration.c <https://reviewboard.asterisk.org/r/4582/#comment25726> Are the flags exclusive to each other? Maybe SUPPORT is needed to enable the functionality and REQUIRE to make it mandatory. branches/13/res/res_pjsip/pjsip_configuration.c <https://reviewboard.asterisk.org/r/4582/#comment25724> Idem branches/13/res/res_pjsip/pjsip_configuration.c <https://reviewboard.asterisk.org/r/4582/#comment25727> Are the flags exclusive to each other? Maybe SUPPORT is needed to enable the functionality and REQUIRE to make it mandatory. Similar for ALWAYS. branches/13/res/res_pjsip/pjsip_configuration.c <https://reviewboard.asterisk.org/r/4582/#comment25725> The documentation for this enum value is needs updating in res_pjsip.c. It is documented as force instead of always. Maybe add force here as an alias of always since it has been documented that way. - rmudgett On April 3, 2015, 2:58 p.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4582/ > ----------------------------------------------------------- > > (Updated April 3, 2015, 2:58 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24910 > https://issues.asterisk.org/jira/browse/ASTERISK-24910 > > > Repository: Asterisk > > > Description > ------- > > When setting the configuration option 'timers' equal to 'no' the bit flag was > not properly negated. This patch clears all associated flags and only sets > the specified one. pjsip will handle any necessary flag combinations. Also > went ahead and did similar for the '100rel' option. > > > Diffs > ----- > > branches/13/res/res_pjsip/pjsip_configuration.c 433966 > > Diff: https://reviewboard.asterisk.org/r/4582/diff/ > > > Testing > ------- > > Made sure the option can now be set to 'no' and that it clears the bit. Also > set it to the other values and reloaded to make sure the field was updated > correctly. > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
