Ashley Sanders has posted comments on this change. Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication ......................................................................
Patch Set 3: (4 comments) I just found a few minor issues regarding docstrings, but everything else looks good. https://gerrit.asterisk.org/#/c/28/3/tests/fax/pjsip/t38_with_auth/run-test File tests/fax/pjsip/t38_with_auth/run-test: Line 33: """ >From the PEP8 documentation >(https://www.python.org/dev/peps/pep-0008/#documentation-strings): "For one liner docstrings, please keep the closing """ on the same line." Line 59: """Verify FAX test results from user events Same here as on lines 32-33. Line 76: def run(self): The method is missing its docstring. Line 81: def main(): This method is also missing its docstring. -- To view, visit https://gerrit.asterisk.org/28 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If37cf20857ae3c0b35e0637a0a2cb7e7d6226df6 Gerrit-PatchSet: 3 Gerrit-Project: testsuite Gerrit-Branch: master Gerrit-Owner: Jonathan Rose <jr...@digium.com> Gerrit-Reviewer: Ashley Sanders <asand...@digium.com> Gerrit-Reviewer: Jonathan Rose <jr...@digium.com> Gerrit-Reviewer: Matt Jordan <mjor...@digium.com> Gerrit-HasComments: Yes -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
