Ashley Sanders has posted comments on this change.

Change subject: sip_attended_transfer now supports pre-12 Asterisk versions.
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

https://gerrit.asterisk.org/#/c/29/3/tests/channels/SIP/sip_attended_transfer/attended_transfer.py
File tests/channels/SIP/sip_attended_transfer/attended_transfer.py:

Line 87: 
Awesome! I didn't realize that this was legal syntax until now.

Bonus points for the icing on the cake.


Line 104:     def bridge_enter(self, _, event):
More bonus points for the icing on the cake.


-- 
To view, visit https://gerrit.asterisk.org/29
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I958c52cebb94f9cfc8dc8ed81311ae62efb2679d
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichel...@digium.com>
Gerrit-Reviewer: Ashley Sanders <asand...@digium.com>
Gerrit-Reviewer: Mark Michelson <mmichel...@digium.com>
Gerrit-Reviewer: Matt Jordan <mjor...@digium.com>
Gerrit-HasComments: Yes

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to