Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error ......................................................................
Patch Set 5: (5 comments) I found some more minor issues with the review. https://gerrit.asterisk.org/#/c/18/5/tests/rest_api/applications/stasisstatus/ari_client.py File tests/rest_api/applications/stasisstatus/ari_client.py: Line 103: if self.__ari is not None: There should be an else-statement here, to clear the list manually if the ari instance is None. https://gerrit.asterisk.org/#/c/18/5/tests/rest_api/applications/stasisstatus/configs/ast1/sip.conf File tests/rest_api/applications/stasisstatus/configs/ast1/sip.conf: Line 9: [acme](!) I am not sure that this template or the sherman endpoint is being used any longer. https://gerrit.asterisk.org/#/c/18/5/tests/rest_api/applications/stasisstatus/monitor.py File tests/rest_api/applications/stasisstatus/monitor.py: Line 29: variable -- The AMI variable to monitor (optional) The description should read: "The name of the channel variable to monitor (optional) (default None). Line 48: return self.__class__.__name__ + '[' + self.name + ']:' This should be handled in the base type, ObservableObject. If it is, this method is safe to delete. https://gerrit.asterisk.org/#/c/18/5/tests/rest_api/applications/stasisstatus/test_case.py File tests/rest_api/applications/stasisstatus/test_case.py: Line 170: None, None is over 1 too many spaces. -- To view, visit https://gerrit.asterisk.org/18 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f7dadfd429bd30e9f07a531f47884d8c923fc13 Gerrit-PatchSet: 5 Gerrit-Project: testsuite Gerrit-Branch: master Gerrit-Owner: Ashley Sanders <asand...@digium.com> Gerrit-Reviewer: Ashley Sanders <asand...@digium.com> Gerrit-Reviewer: Mark Michelson <mmichel...@digium.com> Gerrit-Reviewer: Matt Jordan <mjor...@digium.com> Gerrit-HasComments: Yes -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
