----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4588/#review15152 -----------------------------------------------------------
Ship it! Other than having this get documented in the CHANGES file, this looks good to go. Since that's relatively minor, I'll Ship It. - Matt Jordan On April 9, 2015, 9:21 a.m., Y Ateya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4588/ > ----------------------------------------------------------- > > (Updated April 9, 2015, 9:21 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24939 > https://issues.asterisk.org/jira/browse/ASTERISK-24939 > > > Repository: Asterisk > > > Description > ------- > > The section 4.1 in call token changes to IAX protocol > (http://downloads.asterisk.org/pub/security/IAX2-security.html): > > "The token timeout will be hard coded at 10 seconds for now. However, it may > be made configurable at some point if it seems to be a useful addition" > > In case of lagged network cases (or bad network which required multiple > retries) 10 seconds is not enough. > > Changes: > - Change name of MAX_CALLTOKEN_DELAY to lower case and remove const. > - Add general configuration variable `calltokenexpiration` > > > Diffs > ----- > > trunk/configs/samples/iax.conf.sample 432806 > trunk/channels/chan_iax2.c 432806 > > Diff: https://reviewboard.asterisk.org/r/4588/diff/ > > > Testing > ------- > > > Thanks, > > Y Ateya > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
