Jared K. Smith has posted comments on this change. Change subject: pjsip: Add basic resolver tests covering A/AAAA, SRV, and NAPTR. ......................................................................
Patch Set 1: (10 comments) Lots of red blobs, plus one typo https://gerrit.asterisk.org/#/c/31/1/tests/channels/pjsip/resolver/a/dns_zones/example.com File tests/channels/pjsip/resolver/a/dns_zones/example.com: Line 8: Red blob Line 13: serial = 2003010601, And more red blobs throughout this file https://gerrit.asterisk.org/#/c/31/1/tests/channels/pjsip/resolver/aaaa/dns_zones/example.com File tests/channels/pjsip/resolver/aaaa/dns_zones/example.com: Line 8: Red blobs in this file... https://gerrit.asterisk.org/#/c/31/1/tests/channels/pjsip/resolver/aaaa/test-config.yaml File tests/channels/pjsip/resolver/aaaa/test-config.yaml: Line 4: This test verifies that an AAAAA record lookup successfully occurs using Did you mean AAAA record? I think you've got one too many here... https://gerrit.asterisk.org/#/c/31/1/tests/channels/pjsip/resolver/naptr/transport_tcp/dns_zones/example.com File tests/channels/pjsip/resolver/naptr/transport_tcp/dns_zones/example.com: Line 8: Red blobs... https://gerrit.asterisk.org/#/c/31/1/tests/channels/pjsip/resolver/naptr/transport_udp/dns_zones/example.com File tests/channels/pjsip/resolver/naptr/transport_udp/dns_zones/example.com: Line 8: Red blobs... https://gerrit.asterisk.org/#/c/31/1/tests/channels/pjsip/resolver/naptr/transport_unspecified/dns_zones/example.com File tests/channels/pjsip/resolver/naptr/transport_unspecified/dns_zones/example.com: Line 8: Red blobs https://gerrit.asterisk.org/#/c/31/1/tests/channels/pjsip/resolver/srv/transport_tcp/dns_zones/example.com File tests/channels/pjsip/resolver/srv/transport_tcp/dns_zones/example.com: Line 8: Red blobs https://gerrit.asterisk.org/#/c/31/1/tests/channels/pjsip/resolver/srv/transport_udp/dns_zones/example.com File tests/channels/pjsip/resolver/srv/transport_udp/dns_zones/example.com: Line 8: Red blobs... https://gerrit.asterisk.org/#/c/31/1/tests/channels/pjsip/resolver/srv/transport_unspecified/dns_zones/example.com File tests/channels/pjsip/resolver/srv/transport_unspecified/dns_zones/example.com: Line 8: Red blobs... -- To view, visit https://gerrit.asterisk.org/31 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8690d6b2441937ab9d7fea6f1e41c3d6985a1d9e Gerrit-PatchSet: 1 Gerrit-Project: testsuite Gerrit-Branch: master Gerrit-Owner: Joshua Colp <jc...@digium.com> Gerrit-Reviewer: Jared K. Smith <jaredsm...@jaredsmith.net> Gerrit-HasComments: Yes -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
