> On March 29, 2015, 5:01 a.m., Diederik de Groot wrote: > > /branches/13/configure.ac, line 389 > > <https://reviewboard.asterisk.org/r/4543/diff/6/?file=73280#file73280line389> > > > > move the raii compiler checks to their own m4 file and called the > > checking function a little earlier in the configure process
Is this ok, or would you rather keep everything together in configure.ac. I think splitting out some stuff makes it a little more easy to maintain / test - Diederik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4543/#review14954 ----------------------------------------------------------- On March 29, 2015, 5:15 p.m., Diederik de Groot wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4543/ > ----------------------------------------------------------- > > (Updated March 29, 2015, 5:15 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24917 > https://issues.asterisk.org/jira/browse/ASTERISK-24917 > > > Repository: Asterisk > > > Description > ------- > > RAII-clang reentrancy / Updating variable from inside a _block > > To update the varname variable from inside the cleanup block it needs to be > decorated with "__block" as in: > __block vartype varname = ctor; > > > Diffs > ----- > > /branches/13/include/asterisk/utils.h 433444 > /branches/13/contrib/scan-build PRE-CREATION > /branches/13/configure.ac 433444 > /branches/13/autoconf/ast_check_raii.m4 PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/4543/diff/ > > > Testing > ------- > > > Thanks, > > Diederik de Groot > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
