Hello Corey Farrell, I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/54 to look at the new patch set (#6). Change subject: git migration: Remove support for file versions ...................................................................... git migration: Remove support for file versions Git does not support the ability to replace a token with a version string during check-in. While it does have support for replacing a token on clone, this is somewhat sub-optimal: the token is replaced with the object hash, which is not particularly easy for human consumption. What's more, in practice, the source file version was often not terribly useful. Generally, when triaging bugs, the overall version of Asterisk is far more useful than an individual SVN version of a file. As a result, this patch removes Asterisk's support for showing source file versions. Specifically, it does the following: * main/asterisk: - Refactor the file_version structure to reflect that it no longer tracks a version field. - Remove the "core show file version" CLI command. Without the file version, it is no longer useful. * main/manager: Remove value from the Version key of the ModuleCheck Action. The actual key itself has not been removed, as doing so would absolutely constitute a backwards incompatible change. However, since the file version is no longer tracked, there is no need to attempt to include it in the Version key. * UPGRADE: Add notes for: - Modification to the ModuleCheck AMI Action - Removal of the "core show file version" CLI command Change-Id: Id146f24e9d968dccd64cb09dbfa1da3d9ac719f6 --- M UPGRADE.txt M include/asterisk.h M main/asterisk.c M main/manager.c 4 files changed, 51 insertions(+), 132 deletions(-) git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/54/54/6 -- To view, visit https://gerrit.asterisk.org/54 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id146f24e9d968dccd64cb09dbfa1da3d9ac719f6 Gerrit-PatchSet: 6 Gerrit-Project: asterisk Gerrit-Branch: master Gerrit-Owner: Matt Jordan <mjor...@digium.com> Gerrit-Reviewer: Corey Farrell <g...@cfware.com> Gerrit-Reviewer: Matt Jordan <mjor...@digium.com> -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev