Corey Farrell has posted comments on this change. Change subject: git migration: Remove support for file versions ......................................................................
Patch Set 1: (1 comment) https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c File main/asterisk.c: Line 390: return NULL; > If we did that, we'd have to keep the version field on the struct, and we'd You misunderstand. What I mean is: printf("Version: %s\n", ast_file_version_find("chan_sip.c")); This would print "Version: 11.17.0\n" if chan_sip is loaded. This way the result of this function for file="chan_sip.c" is still not NULL, the result for file="chan_this_doesnt_exist.c" is still NULL. -- To view, visit https://gerrit.asterisk.org/61 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia932d3c64cd18a14a3c894109baa657ec0a85d28 Gerrit-PatchSet: 1 Gerrit-Project: asterisk Gerrit-Branch: 11 Gerrit-Owner: Matt Jordan <mjor...@digium.com> Gerrit-Reviewer: Corey Farrell <g...@cfware.com> Gerrit-Reviewer: Matt Jordan <mjor...@digium.com> Gerrit-HasComments: Yes -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
