Corey Farrell has posted comments on this change. Change subject: PEP8 fixes ......................................................................
Patch Set 2: (2 comments) The PJSIP tests no longer fail. I have a full run of the testsuite going now, so far no issues. https://gerrit.asterisk.org/#/c/40/2/lib/python/asterisk/sip_dialog_test_condition.py File lib/python/asterisk/sip_dialog_test_condition.py: Line 217: if history_requirements[dialog][req] is False: I'm unsure this was needed, but "a == False" is not the same thing as "not a", for example when "a is None". https://gerrit.asterisk.org/#/c/40/2/lib/python/asterisk/test_case.py File lib/python/asterisk/test_case.py: Line 650: if self.passed is False: This was causing the problem because it is possible for "self.passed is None". -- To view, visit https://gerrit.asterisk.org/40 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55bcaab21c54f9040594f51c57f0efe30a219a62 Gerrit-PatchSet: 2 Gerrit-Project: testsuite Gerrit-Branch: master Gerrit-Owner: Corey Farrell <g...@cfware.com> Gerrit-Reviewer: Corey Farrell <g...@cfware.com> Gerrit-Reviewer: George Joseph <george.jos...@fairview5.com> Gerrit-Reviewer: Matt Jordan <mjor...@digium.com> Gerrit-HasComments: Yes -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
