Overall I like it. I think leaving pbx_ael out of this is best as it might not be straight forward. Anyone who wants pbx_ael to provide information about config sources can create a follow-up patch once the core functionality is implemented.
Some thoughts: * It would be nice if the registrar ("pbx_config:") were omitted when config file/line are available. * I assume we can strip 'ast_config_AST_CONFIG_DIR' from included config filenames? I suspect both of these things could be done in follow-up patches, I just want to consider limited terminal width and try to avoid unneeded wrapping. On Wed, Dec 7, 2016 at 1:49 PM, Jonathan Rose <jonathan.r...@motorolasolutions.com> wrote: > I've been working through a lot of complicated dialplan setups lately, > mostly written in AEL. Doing so has left me painfully aware of the fact that > it can sometimes be hard to trace a dialplan through its various extensions. > More so in pbx_ael of course where what you write isn't necessarily matched > in an easy to read way to the extensions you create, but even in pbx_config > it can get slightly tricky to follow when included files are involved or > there is heavy use of 'n' to assign priority. > > So far I've written a patch against trunk which adds in the basic > functionality I'm describing and applies it to extensions created by > pbx_config. I'm not sure if I should bother following it through to > completion since the benefits in pbx_config are limited, I'm unsure of how > many people actually use AEL to write their dialplans, and I'm not entirely > sure if I'm sharp enough to figure out how to add it to AEL in a > non-cataclysmic manner anyway. But I figured I'd at least post here to gauge > people's interest. > > Linked is a picture showing illustrating the difference in my experimental > patch. It would also be fairly trivial to add a similar file/line number tag > to verbose 3 "channel ran extension" messages with the patch I've written. > > http://imgur.com/LCh61fx > > -- > Jonathan R. Rose > Senior Systems Engineer > > Motorola Solutions > > email: jonathan.r...@motorolasolutions.com > > -- > _____________________________________________________________________ > -- Bandwidth and Colocation Provided by http://www.api-digital.com -- > > asterisk-dev mailing list > To UNSUBSCRIBE or update options visit: > http://lists.digium.com/mailman/listinfo/asterisk-dev -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev