Tony Hoyle [EMAIL PROTECTED] wrote: > Kevin Walsh wrote: > > Yes - it does break the distinctive ring detection, but that's easily > > sorted out. > > > Actually it's the first time I've ever heard of distinctive ring being > available in the UK... :) > It costs the same as Caller*ID, so I just got it to separate business and personal calls received at home. I have Asterisk now, so I can be a little bit cleverer and set the times when I want to receive business calls at home etc. :-)
> > > > The "correct" way would be to move the "if (p->use_callerid == 2)" > > code within the existing "if (p->use_callerid)" block, with a couple > > more "if" conditionals here and there. The quick way, however, is > > to apply the attached chan_zap.c hack over the top of Tony Hoyle's > > great work. > > > It needs an extra conditional - no need to add the extra delay before > the phone starts ringing if there's no need to (I prefer my phone to > start ringing immediately). > Yes, but it'd need to ring at least once if the distinctive ring is to be detected. As you said - a conditional should do the trick. > > Try this patch. It also enables distinctive ring detection even if > usecallerid=no. It's not well tested yet (well, at all actually since I > don't have access to distinctive ring...) > I applied your new patch but it resulted in the caller hearing a ring tone but no phones actually ringing. I don't have time to look into it right now, but I'll take a look later and see what's going on. I put my chan_zap.c back in and the re-tests were ok. I has assumed that the only change between your previous patch file and your latest was in chan_zap.c, so I extracted the patch and applied it to that single file only. If that's not the case then I'll have to apply the whole thing. I'll probably have more time later in the day. -- _/ _/ _/_/_/_/ _/ _/ _/_/_/ _/ _/ _/_/_/ _/_/ _/ _/ _/ _/_/ _/ K e v i n W a l s h _/ _/ _/ _/ _/ _/ _/ _/_/ [EMAIL PROTECTED] _/ _/ _/_/_/_/ _/ _/_/_/ _/ _/ _______________________________________________ Asterisk-Users mailing list [EMAIL PROTECTED] http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
