On Tue, 2016-04-05 at 20:58 +0530, Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> > > Return value is incorrect for btcoex and peer stats debugfs > 'write' entries if the user provides a value that matches with > the already available debugfs entry, this results in the debugfs > entry getting stuck and the operation has to be terminated manually. > Fix this by returning the appropriate return 'count' as we do it for > other debugfs entries like pktlog etc
Not your code, but some of the xor uses are odd at best. > diff --git a/drivers/net/wireless/ath/ath10k/debug.c > b/drivers/net/wireless/ath/ath10k/debug.c [] > @@ -2122,7 +2122,7 @@ static ssize_t ath10k_write_btcoex(struct file *file, > struct ath10k *ar = file->private_data; > char buf[32]; > size_t buf_size; > - int ret = 0; > + int ret; > bool val; > > buf_size = min(count, (sizeof(buf) - 1)); > @@ -2142,8 +2142,10 @@ static ssize_t ath10k_write_btcoex(struct file *file, > goto exit; > } > > - if (!(test_bit(ATH10K_FLAG_BTCOEX, &ar->dev_flags) ^ val)) > + if (!(test_bit(ATH10K_FLAG_BTCOEX, &ar->dev_flags) ^ val)) { xor on an int and a bool. > @@ -2189,7 +2191,7 @@ static ssize_t ath10k_write_peer_stats(struct file > *file, > struct ath10k *ar = file->private_data; > char buf[32]; > size_t buf_size; > - int ret = 0; > + int ret; > bool val; > > buf_size = min(count, (sizeof(buf) - 1)); > @@ -2209,8 +2211,10 @@ static ssize_t ath10k_write_peer_stats(struct file > *file, > goto exit; > } > > - if (!(test_bit(ATH10K_FLAG_PEER_STATS, &ar->dev_flags) ^ val)) > + if (!(test_bit(ATH10K_FLAG_PEER_STATS, &ar->dev_flags) ^ val)) { here too _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k