On Wednesday, December 14, 2016 1:03:38 PM CET Mohammed Shafi Shajakhan wrote: > > On Wednesday, December 7, 2016 11:58:24 AM CET Mohammed Shafi Shajakhan > > wrote: > > > On Mon, Dec 05, 2016 at 10:52:45PM +0100, Christian Lamparter wrote: > > > > @@ -409,10 +410,12 @@ void ath10k_debug_fw_stats_process(struct ath10k > > > > *ar, struct sk_buff *skb) > > > > goto free; > > > > } > > > > > > > > + if (!list_empty(&stats.peers)) > > > > > > [shafi] sorry please correct me if i am wrong, for 'extended peer stats' > > > we are checking > > > for normal 'peer stats' ? Is this the fix intended, i had started a build > > > to > > > check your change and we will keep you posted, does this fix displaying > > > 'rx_duration' in ath10k fw_stats. > > The idea is not to queue any "extended peer stats" when there where no > > "peer stats" to > > begin with. Because otherwise, the function is still vulnerable to OOM > > since the > > extended peers stats will be queued unchecked (not that this is currently a > > problem). > > [shafi] list_splice_tail_init should still check for non-empty 'peers_extd' > list > and append if required ? please let me know if i am still missing something Well, you can also count the entries in peers_extd and delete the old entries if they start to overflow. If you want to do it differently, please go ahead.
Regards, Christian _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
