Hi Govind,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on ath6kl/ath-next]
[also build test WARNING on next-20180605]
[cannot apply to v4.17]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Govind-Singh/Add-support-for-wifi-QMI-client-driver/20180606-064401
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   drivers/net/wireless/ath/ath10k/qmi.c: In function 
'ath10k_qmi_msa_mem_info_send_sync_msg':
>> drivers/net/wireless/ath/ath10k/qmi.c:169:61: warning: format '%llx' expects 
>> argument of type 'long long unsigned int', but argument 5 has type 
>> 'phys_addr_t {aka unsigned int}' [-Wformat=]
      ath10k_dbg(ar, ATH10K_DBG_QMI, "mem region: %d Addr: 0x%llx Size: 0x%x 
Flag: 0x%08x\n",
                                                             ~~~^
                                                             %x
          i, qmi->mem_region[i].addr,
             ~~~~~~~~~~~~~~~~~~~~~~~                             

vim +169 drivers/net/wireless/ath/ath10k/qmi.c

   119  
   120  static int ath10k_qmi_msa_mem_info_send_sync_msg(struct ath10k_qmi *qmi)
   121  {
   122          struct wlfw_msa_info_resp_msg_v01 resp = {};
   123          struct wlfw_msa_info_req_msg_v01 req = {};
   124          struct ath10k *ar = qmi->ar;
   125          struct qmi_txn txn;
   126          int ret;
   127          int i;
   128  
   129          req.msa_addr = qmi->msa_pa;
   130          req.size = qmi->msa_mem_size;
   131  
   132          ret = qmi_txn_init(&qmi->qmi_hdl, &txn,
   133                             wlfw_msa_info_resp_msg_v01_ei, &resp);
   134          if (ret < 0)
   135                  goto out;
   136  
   137          ret = qmi_send_request(&qmi->qmi_hdl, NULL, &txn,
   138                                 QMI_WLFW_MSA_INFO_REQ_V01,
   139                                 WLFW_MSA_INFO_REQ_MSG_V01_MAX_MSG_LEN,
   140                                 wlfw_msa_info_req_msg_v01_ei, &req);
   141          if (ret < 0) {
   142                  qmi_txn_cancel(&txn);
   143                  ath10k_err(ar, "fail to send msa mem info req %d\n", 
ret);
   144                  goto out;
   145          }
   146  
   147          ret = qmi_txn_wait(&txn, WLFW_TIMEOUT * HZ);
   148          if (ret < 0)
   149                  goto out;
   150  
   151          if (resp.resp.result != QMI_RESULT_SUCCESS_V01) {
   152                  ath10k_err(ar, "msa info req rejected, err:%d\n", 
resp.resp.error);
   153                  ret = -EINVAL;
   154                  goto out;
   155          }
   156  
   157          if (resp.mem_region_info_len > QMI_WLFW_MAX_MEM_REG_V01) {
   158                  ath10k_err(ar, "invalid memory region length received: 
%d\n",
   159                             resp.mem_region_info_len);
   160                  ret = -EINVAL;
   161                  goto out;
   162          }
   163  
   164          qmi->nr_mem_region = resp.mem_region_info_len;
   165          for (i = 0; i < resp.mem_region_info_len; i++) {
   166                  qmi->mem_region[i].addr = 
resp.mem_region_info[i].region_addr;
   167                  qmi->mem_region[i].size = resp.mem_region_info[i].size;
   168                  qmi->mem_region[i].secure = 
resp.mem_region_info[i].secure_flag;
 > 169                  ath10k_dbg(ar, ATH10K_DBG_QMI, "mem region: %d Addr: 
 > 0x%llx Size: 0x%x Flag: 0x%08x\n",
   170                             i, qmi->mem_region[i].addr,
   171                             qmi->mem_region[i].size,
   172                             qmi->mem_region[i].secure);
   173          }
   174  
   175          ath10k_dbg(ar, ATH10K_DBG_QMI, "msa mem info request 
completed\n");
   176          return 0;
   177  
   178  out:
   179          return ret;
   180  }
   181  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Reply via email to