On Thu, 2018-09-20 at 17:30 -0700, Pradeep Kumar Chitrapu wrote: > New bss param ftm_responder is used to notify the driver to > enable fine timing request (FTM) responder role in AP mode. > > Plumb the new cfg80211 API for FTM responder statistics through to > the driver API in mac80211.
This patch also doesn't apply right now, please rebase & add the struct as previously pointed out. That also affects the driver, perhaps, so please resend that as well. > + if (params->ftm_responder != -1) { > + sdata->vif.bss_conf.ftm_responder = params->ftm_responder; > + err = ieee80211_set_ftm_responder_params(sdata, > + params->lci, > + params->lci_len, > + params->civicloc, > + params->civicloc_len); > + > + if (err < 0) > + return err; > + > + changed |= BSS_CHANGED_FTM_RESPONDER; > + } else { > + sdata->vif.bss_conf.ftm_responder = -1; > + } This seems wrong - you should remove the else branch entirely, afaict? I think you may also be missing some freeing of the ftm_responder_params in the end if it didn't get disabled again, but the interface is removed? johannes _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k