Hi,
Was waiting for you to address Sergey's feedback, but now that I looked
anyway, I have some of my own. Sorry for the long delay though!
> + * @NL80211_ATTR_TID_CONFIG: TID specific configuration in a
> + * nested attribute with %NL80211_TID_ATTR_* sub-attributes.
Please use NL80211_TID_CONFIG_ATTR_* throughout, also for
> +/* enum nl80211_tid_attr_config - TID specific configuration.
the enum name
> +enum nl80211_tid_attr_config {
> + __NL80211_TID_ATTR_INVALID,
> + NL80211_TID_ATTR_CONFIG_TID,
> + NL80211_TID_ATTR_CONFIG_NOACK,
> +
> + /* keep last */
> + __NL80211_TID_ATTR_CONFIG_AFTER_LAST,
> + NL80211_TID_ATTR_CONFIG_MAX = __NL80211_TID_ATTR_CONFIG_AFTER_LAST - 1
and all the things in it.
Also, as you can see above, the kernel-doc comment isn't formatted
right.
> + nla_for_each_nested(tid, info->attrs[NL80211_ATTR_TID_CONFIG],
> + rem_conf) {
> + ret = nla_parse_nested_deprecated(attrs,
> NL80211_TID_ATTR_CONFIG_MAX,
> + tid, NULL, NULL);
You shouldn't use _deprecated.
> + ret = parse_tid_conf(rdev, attrs,
> + &tid_config->tid_conf[conf_idx],
> + tid_config->peer);
and yeah, this should compile.
johannes
