On Mon, 2020-10-19 at 10:54 -0500, Gustavo A. R. Silva wrote:
> On 10/19/20 10:21, Joe Perches wrote:
> > On Mon, 2020-10-19 at 17:14 +0200, Christian Lamparter wrote:
> > > On 19/10/2020 17:05, t...@redhat.com wrote:
> > > > From: Tom Rix <t...@redhat.com>
> > > >
> > > > A break is not needed if it is preceded by a return or goto
> > > >
> > > > Signed-off-by: Tom Rix <t...@redhat.com>
> > > > diff --git a/drivers/net/wireless/intersil/p54/eeprom.c
> > > > b/drivers/net/wireless/intersil/p54/eeprom.c
[]
> > > > @@ -870,7 +870,6 @@ int p54_parse_eeprom(struct ieee80211_hw *dev, void
> > > > *eeprom, int len)
> > > > } else {
> > > > goto good_eeprom;
> > > > }
> > > > - break;
> > > Won't the compiler (gcc) now complain about a missing fallthrough
> > > annotation?
>
> Clang would definitely complain about this.
As far as I can tell, clang 10.0.0 doesn't complain.
This compiles without fallthrough complaint
from make V=1 W=123 CC=clang drivers/net/wireless/intersil/p54/eeprom.o
with -Wimplicit-fallthrough added
$ clang -Wp,-MMD,drivers/net/wireless/intersil/p54/.eeprom.o.d -nostdinc
-isystem /usr/local/lib/clang/10.0.0/include -I./arch/x86/include
-I./arch/x86/include/generated -I./include -I./arch/x86/include/uapi
-I./arch/x86/include/generated/uapi -I./include/uapi -I./include/generated/uapi
-include ./include/linux/kconfig.h -include ./include/linux/compiler_types.h
-D__KERNEL__ -Qunused-arguments -DKBUILD_EXTRA_WARN1 -DKBUILD_EXTRA_WARN2
-DKBUILD_EXTRA_WARN3 -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs
-fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE
-Werror=implicit-function-declaration -Werror=implicit-int -Wno-format-security
-std=gnu89 -no-integrated-as -Werror=unknown-warning-option -mno-sse -mno-mmx
-mno-sse2 -mno-3dnow -mno-avx -m64 -mno-80387 -mstack-alignment=8
-mtune=generic -mno-red-zone -mcmodel=kernel -DCONFIG_X86_X32_ABI
-Wno-sign-compare -fno-asynchronous-unwind-tables -mretpoline-external-thunk
-fno-delete-null-pointer-checks -Wno-address-of-packed-member -O2
-Wframe-larger-than=2048 -fstack-protector-strong -Wno-format-invalid-specifier
-Wno-gnu -mno-global-merge -Wno-unused-const-variable
-ftrivial-auto-var-init=pattern -pg -mfentry -DCC_USING_FENTRY
-falign-functions=32 -Wdeclaration-after-statement -Wvla -Wno-pointer-sign
-Wno-array-bounds -fno-strict-overflow -fno-stack-check -Werror=date-time
-Werror=incompatible-pointer-types -fcf-protection=none -Wextra -Wunused
-Wno-unused-parameter -Wmissing-declarations -Wmissing-format-attribute
-Wmissing-prototypes -Wold-style-definition -Wmissing-include-dirs
-Wunused-const-variable -Wno-missing-field-initializers -Wno-sign-compare
-Wno-type-limits -Wcast-align -Wdisabled-optimization -Wnested-externs -Wshadow
-Wmissing-field-initializers -Wtype-limits -Wunused-macros -Wbad-function-cast
-Wcast-qual -Wconversion -Wpacked -Wpadded -Wpointer-arith -Wredundant-decls
-Wsign-compare -Wswitch-default -fsanitize=kernel-address -mllvm
-asan-mapping-offset=0xdffffc0000000000 -mllvm -asan-globals=1 -mllvm
-asan-instrumentation-with-call-threshold=0 -mllvm -asan-stack=0 --param
asan-instrument-allocas=1 -fsanitize-coverage=trace-pc
-fsanitize-coverage=trace-cmp -Wimplicit-fallthrough
-DKBUILD_MODFILE='"drivers/net/wireless/intersil/p54/p54common"'
-DKBUILD_BASENAME='"eeprom"' -DKBUILD_MODNAME='"p54common"' -c -o
drivers/net/wireless/intersil/p54/eeprom.o
drivers/net/wireless/intersil/p54/eeprom.c
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
