On Fri, Oct 31, 2025 at 11:00 PM Jeff Johnson <[email protected]> wrote: > > On 10/31/2025 4:16 AM, Zhi-Jun You wrote: > > Remove is_mgmt from ath10k_htt_tx_mgmt_inc_pending and make sure we only > > call it when it's a mgmt frame. > > This fails to describe WHY the patch is needed > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
Hi Jeff, My apologies. I will try to describe it in this mail and update it in v2 if it looks good to you. ath10k_htt_tx_mgmt_inc_pending() is called in ath10k_mac_tx_push_txq() and ath10k_mac_op_tx(). In ath10k_mac_tx_push_txq(), it checks is_mgmt before calling ath10k_htt_tx_mgmt_inc_pending() but there's another is_mgmt check inside which looks redundant. The function name itself already indicates that it's for mgmt frame only. This patch removed the is_mgmt check in ath10k_htt_tx_mgmt_inc_pending() and add an is_mgmt check in ath10k_mac_op_tx() to make sure it's only called for mgmt frames. Thanks for taking your time. Best regards, Zhi-Jun
