On 14/11/2025 12:44, Srinivas Kandagatla wrote:
> On 11/14/25 11:24 AM, Krzysztof Kozlowski wrote:
>> On 14/11/2025 12:16, Manivannan Sadhasivam wrote:
>>>>>
>>>>> +static const struct __ath_calib_variant_table {
>>>>> + const char *machine;
>>>>> + const char *variant;
>>>>> +} ath_calib_variant_table[] = {
>>>>> + { "ALFA Network AP120C-AC", "ALFA-Network-AP120C-AC" },
>>>>> + { "8devices Jalapeno", "8devices-Jalapeno" },
>>>>> + { "Google cozmo board", "GO_COZMO" },
>>>>> + { "Google damu board", "GO_DAMU" },
>>>>> + { "Google fennel sku1 board", "GO_FENNEL" },
>>>>> + { "Google fennel sku6 board", "GO_FENNEL" },
>>>>> + { "Google fennel sku7 board", "GO_FENNEL" },
>>>>
>>>> Are these top-machine models? If so, you cannot use them. The value is
>>>> user-informative, not ABI. If you wanted to use them, you would need to
>>>> document the ABI.
>
> the value has expected format, can it not be an ABI?, from DT Specs:
Where is the ABI documented? You should not have ABI which is completely
undocumented.
> "Specifies a string that uniquely identifies the model of the system
> board" We can argue that its not part of
> Documentation/devicetree/bindings/arm/qcom.yaml
>
> @Mani, can you not use the top level machine compatibles instead,
> something like: "google,fennel-sku7" instead of "Google fennel sku7
> board" which is an ABI.
>
>>>>
>>>
>>> I had this question initially, but Srini convinced me it is OK to use it in
>>> the
>>> driver as they do it in audio :)
>>
>> That's sounds like an issue which could be fixed or at least discussed.
>> There is no in-kernel usage of ASoC's 'model' property, thus we probably
>> never noticed that it is an ABI.
>>
> model is actually used as soundcard name and long name if there is no
> DMI info for the platform, This string is also used at the UCM level to
> identify the correct UCM configuration.
You speak about user-space... I did not dispute that. I said - it is not
used in the kernel.
> >
> However the model that we are referring for sound is part of the
> dt-bindings for the sound card, not the top-level model, so this is an
> ABI for soundcard itself.
We speak about the values. They are not defined as ABI and not used in
the kernel.
Best regards,
Krzysztof
