On Wed, Dec 31, 2025 at 01:04:56PM +0100, Konrad Dybcio wrote:
> On 12/31/25 12:35 AM, Dmitry Baryshkov wrote:
> > WCN3998 uses a bit different format for rom version:
> >
> > [ 5.479978] Bluetooth: hci0: setting up wcn399x
> > [ 5.633763] Bluetooth: hci0: QCA Product ID :0x0000000a
> > [ 5.645350] Bluetooth: hci0: QCA SOC Version :0x40010224
> > [ 5.650906] Bluetooth: hci0: QCA ROM Version :0x00001001
> > [ 5.665173] Bluetooth: hci0: QCA Patch Version:0x00006699
> > [ 5.679356] Bluetooth: hci0: QCA controller version 0x02241001
> > [ 5.691109] Bluetooth: hci0: QCA Downloading qca/crbtfw21.tlv
> > [ 6.680102] Bluetooth: hci0: QCA Downloading qca/crnv21.bin
> > [ 6.842948] Bluetooth: hci0: QCA setup on UART is completed
> >
> > Fixes: 523760b7ff88 ("Bluetooth: hci_qca: Added support for WCN3998")
> > Signed-off-by: Dmitry Baryshkov <[email protected]>
> > ---
> > drivers/bluetooth/btqca.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> > index 7c958d6065be..86a48d009d1b 100644
> > --- a/drivers/bluetooth/btqca.c
> > +++ b/drivers/bluetooth/btqca.c
> > @@ -804,6 +804,8 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t
> > baudrate,
> > */
> > if (soc_type == QCA_WCN3988)
> > rom_ver = ((soc_ver & 0x00000f00) >> 0x05) | (soc_ver &
> > 0x0000000f);
> > + else if (soc_type == QCA_WCN3998)
> > + rom_ver = ((soc_ver & 0x0000f000) >> 0x07) | (soc_ver &
> > 0x0000000f);
> > else
> > rom_ver = ((soc_ver & 0x00000f00) >> 0x04) | (soc_ver &
> > 0x0000000f);
>
> This looks like rom_ver is essentially maj|min or so with min = 4lsb and
> maj being a couple bits up.. no big deal in the end, but this could be
> expressed more nicely
Well, I'm also unsure about the WCN39998 one. Maybe I got it incorrectly
(I couldn't find any definite documentation about these versions).
--
With best wishes
Dmitry
