hello! today did some tracing with madwifi on AR5212/PHY5111/2111 and AR5414 based cards and i noticed that the function ath_hal_get_channel_noise() does not actually read any registers. that means it must return the noise value from some HAL internal state.
that also means calling this function in ath_uapsd_processtriggers() to update the noise per rx descriptor (in IRQ context btw!) is superfluous. i'm not quite sure (yet) where the noise is actually read from, probably ath_hal_calibrate() - unless the HAL reads the noise from some register i don't know about. so it would be enough to update ic->ic_channoise after that and only read that value in ath_uapsd_processtriggers(), especially since ath_uapsd_processtriggers() is in IRQ context and should be as efficient as possible. since the noise is not updated that often anyways, we might even consider to move it into the rx tasklet. bruno _______________________________________________ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
