2008/7/18 Pavel Roskin <[EMAIL PROTECTED]>:
> MSI is a nice thing, but we cannot enable it without changing the
> interrupt handler. If we do it, we break MSI capable hardware,
> specifically AR5006 chipset.
>
> Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]>
> ---
>
> drivers/net/wireless/ath5k/base.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/ath5k/base.c
> b/drivers/net/wireless/ath5k/base.c
> index 635b9ac..e57905c 100644
> --- a/drivers/net/wireless/ath5k/base.c
> +++ b/drivers/net/wireless/ath5k/base.c
> @@ -487,9 +487,6 @@ ath5k_pci_probe(struct pci_dev *pdev,
> /* Set private data */
> pci_set_drvdata(pdev, hw);
>
> - /* Enable msi for devices that support it */
> - pci_enable_msi(pdev);
> -
> /* Setup interrupt handler */
> ret = request_irq(pdev->irq, ath5k_intr, IRQF_SHARED, "ath", sc);
> if (ret) {
> @@ -567,7 +564,6 @@ err_ah:
> err_irq:
> free_irq(pdev->irq, sc);
> err_free:
> - pci_disable_msi(pdev);
> ieee80211_free_hw(hw);
> err_map:
> pci_iounmap(pdev, mem);
> @@ -589,7 +585,6 @@ ath5k_pci_remove(struct pci_dev *pdev)
> ath5k_detach(pdev, hw);
> ath5k_hw_detach(sc->ah);
> free_irq(pdev->irq, sc);
> - pci_disable_msi(pdev);
> pci_iounmap(pdev, sc->iobase);
> pci_release_region(pdev, 0);
> pci_disable_device(pdev);
>
>
> --
> Regards,
> Pavel Roskin
>
This is needed for all pci-e devices since enabling msi results no interrupts...
Acked-by: Nick Kossifidis <[EMAIL PROTECTED]>
--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
_______________________________________________
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
