On Wed, Mar 11, 2009 at 4:15 AM, Tulio Magno Quites Machado Filho
<[email protected]> wrote:
> On Wed, Mar 11, 2009 at 12:39 AM, Maxim Levitsky
> <[email protected]> wrote:
>> If I unload/reload the ath5k, it seems to work. but at next suspend to
>> disk, once system hung, other time it showed many panic, in something
>> related to page allocator (one even was in page_alloc_pages or so)
>
> I'm getting some Kernel oopses after unloading ath5k with Nick patches.
> But I'm still debugging it to find where is the problem.
Ditto here.. looks like a bug in ath5k_eeprom_free_pcal_info(), which has:
struct ath5k_pdgain_info *pd = &chinfo->pd_curves[pdg];
if (pd != NULL) {
kfree(pd->pd_step);
kfree(pd->pd_pwr);
kfree(pd);
}
kfree(pd) looks wrong, because pd_curves is the kzalloc()ed part, not
the array elements themselves. But I tried removing that and freeing
the pd_curves array outside of the loop and got more slab debugging
poop. So, I punt for now.
Also, every alloc of pd_step, and pd_pwr can potentially leak earlier
allocated memory on ENOMEM.
--
Bob Copeland %% www.bobcopeland.com
_______________________________________________
ath5k-devel mailing list
[email protected]
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
