On Fri, 2009-04-10 at 11:11 -0700, Luis R. Rodriguez wrote:

> Thanks pavel, please try this patch:

I checked ath5k, ath9k and b43, and in all cases last_request is
initialized before it's used by the code changed in your patch.  In
fact, last_request is initialized before there is any message from ath5k
or another driver.

I wonder if "module: create a request_module_nowait()" reverted in
wireless-testing was causing the initialization to go in a different
order.  I tried reapplying it and still could not reproduce the problem
(that is, last_request is not NULL in wiphy_update_regulatory).  But
maybe I'm just lucky.

Anyway, your patch makes the code safer and doesn't break anything for
me.

-- 
Regards,
Pavel Roskin
_______________________________________________
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Reply via email to