On Thu, Apr 16, 2009 at 03:29:51AM +0300, Nick Kossifidis wrote: > * Fix num_tx_pending function, we never read the register :P that's why we > got all those "beacon queue 7 didn't stop messages". > > @@ -160,7 +160,8 @@ u32 ath5k_hw_num_tx_pending(struct ath5k_hw *ah, unsigned > int queue) > if (ah->ah_version == AR5K_AR5210) > return false;
This was pre-existing code, but what's with ath5k_hw_num_tx_pending returning true and false in some cases when it's supposed to return a u32? > - pending = (AR5K_QUEUE_STATUS(queue) & AR5K_QCU_STS_FRMPENDCNT); > + pending = ath5k_hw_reg_read(ah, AR5K_QUEUE_STATUS(queue)); > + pending &= AR5K_QCU_STS_FRMPENDCNT; Heh, oops. -- Bob Copeland %% www.bobcopeland.com _______________________________________________ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
