On Wed, May 13, 2009 at 11:14:39AM -0400, Bob Copeland wrote:
>
> From: Forrest Zhang <forr...@hifulltech.com>
>
> Commit e8f055f0c3ba226ca599c14c2e5fe829f6f57cbb subtly changed the
> code that computes floating point values for the PHY3_TIMING register
> such that the exponent is off by a decimal point, which can cause
> problems with OFDM channel operation.
>
> get_bitmask_order() actually returns the highest bit set plus one,
> whereas the previous code wanted the highest bit set. Instead, use
> ilog2 which is what this code is really calculating. Also check
> coef_scaled to handle the (invalid) case where we need log2(0).
>
> Signed-off-by: Bob Copeland <m...@bobcopeland.com>
> ---
>
> John, this plus 706d64453cce7179e05924c24d87777584a1275c fixes a
> regression for 2.6.30 5ghz operation (bugzilla 13077). Any chance
> they can both make it in? I can send a backport of this patch if
> you like (usual path change).
That's fine. But what about this last bit?
http://bugzilla.kernel.org/show_bug.cgi?id=13077#c6
Is that not needed?
John
--
John W. Linville Someday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
_______________________________________________
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
