On Mon, 2009-08-24 at 23:00 -0400, Bob Copeland wrote: > + ah->ah_aes_support = > + (ee->ee_version >= AR5K_EEPROM_VERSION_5_0 && > + !AR5K_EEPROM_AES_DIS(ee->ee_misc5) && > + (ah->ah_mac_version > (AR5K_SREV_AR5212 >> 4) || > + (ah->ah_mac_version == (AR5K_SREV_AR5212 >> 4) && > + ah->ah_mac_revision >= (AR5K_SREV_AR5211 >> 4))));
The above use of ah->ah_mac_revision is clearly incorrect. You are comparing a revision with a symbol for a version. I suggest that you use ah_mac_srev instead. Before this patch, ah_mac_revision was a write-only variable and was a good candidate for removal. The last three quoted lines are equivalent to (ah->ah_mac_srev >= 0x54) -- Regards, Pavel Roskin _______________________________________________ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
