Hi Bruno,

El 17/03/2010 9:47, Bruno Randolf escribió:
> +
> +/*** ANI parameters ***/
> +
> +void
> +ath5k_ani_set_noise_immunity(struct ath5k_hw *ah, bool on)
> +{
> +     const int sz[] = { -55, -62 };
> +     const int lo[] = { -64, -70 };
> +     const int hi[] = { -14, -12 };
> +     const int sg[] = { -78, -80 };

        Why not use the 5 levels table mentioned on the patent? Also for ath9k?

> +static int
> +ath5k_hw_ani_get_listen_time(struct ath5k_hw *ah)
> +{
> +     struct ath5k_statistics *stats = &ah->ah_sc->stats;
> +
> +     /* freeze */
> +     ath5k_hw_reg_write(ah, AR5K_MIBC, AR5K_MIBC_FMC);

        register and value mixed?

> +     /* read */
> +     stats->pfc_cycles = ath5k_hw_reg_read(ah, AR5K_PROFCNT_CYCLE);
> +     stats->pfc_rxclr = ath5k_hw_reg_read(ah, AR5K_PROFCNT_RXCLR);
> +     stats->pfc_tx = ath5k_hw_reg_read(ah, AR5K_PROFCNT_TX);
> +     stats->pfc_rx = ath5k_hw_reg_read(ah, AR5K_PROFCNT_RX);
> +     /* clear */
> +     ath5k_hw_reg_write(ah, 0, AR5K_PROFCNT_TX);
> +     ath5k_hw_reg_write(ah, 0, AR5K_PROFCNT_RX);
> +     ath5k_hw_reg_write(ah, 0, AR5K_PROFCNT_RXCLR);
> +     ath5k_hw_reg_write(ah, 0, AR5K_PROFCNT_CYCLE);
> +     /* un-freeze */
> +     ath5k_hw_reg_write(ah, AR5K_MIBC, 0);

        ditto?

> +static void
> +ath5k_enable_phy_err_counters(struct ath5k_hw *ah)
> +{
> +     ath5k_hw_update_mib_counters(ah);       /* clear all */
> +     ath5k_hw_reg_write(ah, AR5K_MIBC, 0);   /* enable, just in case */

        ditto.

>  
> @@ -2727,13 +2733,21 @@ ath5k_tasklet_calibrate(unsigned long data)
>  {
>       struct ath5k_softc *sc = (void *)data;
>       struct ath5k_hw *ah = sc->ah;
> +     static unsigned long next_full;

        Wrong with several cards installed?


-- 
==============================================================
Jorge Boncompte - Ingenieria y Gestion de RED
DTI2 - Desarrollo de la Tecnologia de las Comunicaciones
--------------------------------------------------------------
C/ Abogado Enriquez Barrios, 5   14004 CORDOBA (SPAIN)
Tlf: +34 957 761395 / FAX: +34 957 450380
==============================================================
- Sin pistachos no hay Rock & Roll...
- Without wicker a basket cannot be made.
==============================================================

_______________________________________________
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel

Reply via email to